Add CrystalToolkitAnimationScene to phonon component#476
Merged
tschaume merged 18 commits intomaterialsproject:mainfrom Oct 24, 2025
Merged
Add CrystalToolkitAnimationScene to phonon component#476tschaume merged 18 commits intomaterialsproject:mainfrom
tschaume merged 18 commits intomaterialsproject:mainfrom
Conversation
This reverts commit 56497f2.
for more information, see https://pre-commit.ci
1 task
tschaume
reviewed
Oct 22, 2025
Member
|
@minhsueh I took a pass at the code. Please review and test. Thank you! |
Collaborator
Author
|
@tschaume I've cleaned up the code, renamed several variables for clarity, and added explanations about how the |
tschaume
approved these changes
Oct 24, 2025
Member
|
Thank you for adding this @minhsueh! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes:
CrystalToolkitAnimationSceneto the phonon component